[ 
https://issues.apache.org/jira/browse/HAWQ-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15267679#comment-15267679
 ] 

ASF GitHub Bot commented on HAWQ-703:
-------------------------------------

Github user hornn commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/633#discussion_r61818778
  
    --- Diff: 
pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/HiveUtilities.java
 ---
    @@ -88,94 +90,61 @@ public static Table getHiveTable(HiveMetaStoreClient 
client, Metadata.Item itemN
          * Unsupported types will result in an exception.
          * <br>
          * The supported mappings are:<ul>
    -     * <li>{@code tinyint -> int2}</li>
    -     * <li>{@code smallint -> int2}</li>
    -     * <li>{@code int -> int4}</li>
    -     * <li>{@code bigint -> int8}</li>
    -     * <li>{@code boolean -> bool}</li>
    -     * <li>{@code float -> float4}</li>
    -     * <li>{@code double -> float8}</li>
    -     * <li>{@code string -> text}</li>
    -     * <li>{@code binary -> bytea}</li>
    -     * <li>{@code timestamp -> timestamp}</li>
    -     * <li>{@code date -> date}</li>
    -     * <li>{@code decimal(precision, scale) -> numeric(precision, 
scale)}</li>
    -     * <li>{@code varchar(size) -> varchar(size)}</li>
    -     * <li>{@code char(size) -> bpchar(size)}</li>
    +         * <li>{@code tinyint -> int2}</li>
    --- End diff --
    
    indentation?


> Serialize HCatalog Complex Types to plain text (as Hive profile)
> ----------------------------------------------------------------
>
>                 Key: HAWQ-703
>                 URL: https://issues.apache.org/jira/browse/HAWQ-703
>             Project: Apache HAWQ
>          Issue Type: New Feature
>          Components: Hcatalog, PXF
>            Reporter: Oleksandr Diachenko
>            Assignee: Oleksandr Diachenko
>
> As for now user is able to create external HAWQ table on top of Hive table 
> with complex types(LIST, MAP, STRUCT, UNION) and those types are being 
> serialized as TEXT.
> But if user uses HCatalog integration feature and queries Hive tables having 
> compex type columns through HAWQ he/she gets error.
> The goal is to serialize complex types to text when using HCatalog 
> integration.
> Changes required:
> - PXF:
>  -- add sourceType field to getMetadata endpoint.
> - HAWQ:
>  -- master:
>  --- update stored procedure pxf_get_item_fields, add sourceType field to 
> responce.
>  -- psql: 
> --- update describe logic for Hive tables to show sourceType column in \d(\d+)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to