[ 
https://issues.apache.org/jira/browse/HAWQ-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304330#comment-15304330
 ] 

ASF GitHub Bot commented on HAWQ-760:
-------------------------------------

Github user zhangh43 commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/679#discussion_r64934846
  
    --- Diff: src/test/feature/testhawqregister/test-hawq-register.cpp ---
    @@ -0,0 +1,80 @@
    +#include <string>
    +
    +#include "lib/command.h"
    +#include "lib/common.h"
    +#include "lib/sql-util.h"
    +
    +#include "gtest/gtest.h"
    +
    +using std::string;
    +
    +/* This test suite may consume more than 80 seconds. */
    +class TestHawqRegister : public ::testing::Test {
    + public:
    +  TestHawqRegister() {}
    +  ~TestHawqRegister() {}
    +};
    +
    +TEST_F(TestHawqRegister, TestSingleFile) {
    +   SQLUtility util;
    +   string rootPath(util.getTestRootPath()); 
    +   string relativePath("/testhawqregister/test_hawq.paq");
    +   string filePath = rootPath + relativePath;
    +
    +   EXPECT_EQ(Command::getCommandStatus("hadoop fs -put " + filePath + " 
/hawq_register_hawq.paq"), 0);
    --- End diff --
    
    EXPECT_EQ(expected_value, your_value), so zero should be the first 
parameter.
    some other EXPECT_EQ has the same problem.


> Hawq register
> -------------
>
>                 Key: HAWQ-760
>                 URL: https://issues.apache.org/jira/browse/HAWQ-760
>             Project: Apache HAWQ
>          Issue Type: New Feature
>          Components: Command Line Tools
>            Reporter: Yangcheng Luo
>            Assignee: Lei Chang
>
> Users sometimes want to register data files generated by other system like 
> hive into hawq. We should add register function to support registering 
> file(s) generated by other system like hive into hawq. So users could 
> integrate their external file(s) into hawq conveniently.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to