[
https://issues.apache.org/jira/browse/HAWQ-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15317690#comment-15317690
]
ASF GitHub Bot commented on HAWQ-774:
-------------------------------------
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/691#discussion_r66001516
--- Diff: src/backend/catalog/pg_compression.c ---
@@ -437,10 +554,11 @@ compresstype_is_valid(char *comptype)
cql("SELECT COUNT(*) FROM
pg_compression "
" WHERE compname = :1 ",
NameGetDatum(&compname))));
-
+
+ /* FIXME: This is a hack. Should register gzip handlers into
pg_compression table. */
if(!found)
{
- if((strcmp(comptype, "snappy") == 0) || strcmp(comptype,
"gzip") == 0)
+ if(strcmp(comptype, "gzip") == 0)
--- End diff --
It's better we remove this hack finally. Since this commit is for snappy
support for AO, let's move removing gzip hack to another JIRA.
> Add snappy compression support to row oriented storage
> ------------------------------------------------------
>
> Key: HAWQ-774
> URL: https://issues.apache.org/jira/browse/HAWQ-774
> Project: Apache HAWQ
> Issue Type: New Feature
> Components: Storage
> Reporter: Paul Guo
> Assignee: Paul Guo
> Labels: oss
> Fix For: 2.0.0-beta-incubating
>
>
> We'd better remove the quicklz compression due to the license reason, thus we
> need a new good compression algorithm which has high compression speed with a
> reasonable compression ratio. Google snappy is a good choice.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
