[ 
https://issues.apache.org/jira/browse/HAWQ-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15332926#comment-15332926
 ] 

ASF GitHub Bot commented on HAWQ-822:
-------------------------------------

Github user xunzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/721#discussion_r67279074
  
    --- Diff: src/test/feature/lib/file_replace.h ---
    @@ -0,0 +1,26 @@
    +#ifndef SRC_TEST_FEATURE_LIB_FILE_REPLACE_H_
    +#define SRC_TEST_FEATURE_LIB_FILE_REPLACE_H_
    +
    +#include <string>
    +#include <map>
    +
    +namespace hawq {
    +namespace test {
    +
    +class FileReplace
    +{
    +public:
    +   FileReplace() {}
    +   ~FileReplace() {}
    --- End diff --
    
    Do you mean not to define the copy constructor here? If you don't define 
anyone of constructor, de-constructor, copy constructor, the compiler will auto 
create them. If you do define some of them, the other could not be auto created.


> Add string replacement utility in feature test framework to support convert 
> from source to sql and ans files
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: HAWQ-822
>                 URL: https://issues.apache.org/jira/browse/HAWQ-822
>             Project: Apache HAWQ
>          Issue Type: Test
>          Components: Tests
>            Reporter: Ruilong Huo
>            Assignee: Ruilong Huo
>
> Need to add string replacement utility in feature test framework to support 
> convert from source to sql and ans files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to