[ 
https://issues.apache.org/jira/browse/HAWQ-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352329#comment-15352329
 ] 

ASF GitHub Bot commented on HAWQ-814:
-------------------------------------

Github user huor commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/752#discussion_r68696245
  
    --- Diff: src/test/feature/lib/share_library_gen.cpp ---
    @@ -0,0 +1,45 @@
    +#include <iostream>
    +#include <fstream>
    +#include <unordered_map>
    +
    +#include "command.h"
    +#include "sql_util.h"
    +#include "file_replace.h"
    +#include "share_library_gen.h"
    +
    +using std::string;
    +using std::unordered_map;
    +
    +namespace hawq {
    +namespace test {
    +
    +void ShareLibraryGen::generate(const string& src_file_dir,
    +                               const string& src_file_name,
    +                               const string& lib_file_name)
    +{
    +   // Generate Makefile dynamically
    +   hawq::test::SQLUtility util;
    +   auto feature_test_root = util.getTestRootPath();
    --- End diff --
    
    Sounds great.


> Add feature test for create_function_1 of user-defined function using new 
> feature test framework
> ------------------------------------------------------------------------------------------------
>
>                 Key: HAWQ-814
>                 URL: https://issues.apache.org/jira/browse/HAWQ-814
>             Project: Apache HAWQ
>          Issue Type: Test
>          Components: Tests
>    Affects Versions: 2.0.0
>            Reporter: Ruilong Huo
>            Assignee: Ruilong Huo
>
> Need to migrate create_function_1 test in installcheck-good to new feature 
> test framework.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to