Github user xunzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/787#discussion_r70556665
  
    --- Diff: src/test/feature/type/ans/int8.ans ---
    @@ -175,131 +179,131 @@ SELECT '' AS to_char_4, to_char( (q1 * -1), 
'9999999999999999S'), to_char( (q2 *
     SELECT '' AS to_char_5,  to_char(q2, 'MI9999999999999999')     FROM 
INT8_TBL  ;
      to_char_5 |      to_char      
     -----------+-------------------
    -           |               123
                |               456
                |  4567890123456789
    +           |               123
                |  4567890123456789
                | -4567890123456789
     (5 rows)
     
     SELECT '' AS to_char_6,  to_char(q2, 'FMS9999999999999999')    FROM 
INT8_TBL  ;
      to_char_6 |      to_char      
     -----------+-------------------
    -           | +123
                | +456
    -           | -4567890123456789
                | +4567890123456789
    +           | +123
                | +4567890123456789
    +           | -4567890123456789
     (5 rows)
     
     SELECT '' AS to_char_7,  to_char(q2, 'FM9999999999999999THPR') FROM 
INT8_TBL ;
      to_char_7 |      to_char       
     -----------+--------------------
    -           | 123RD
    -           | <4567890123456789>
    +           | 456TH
                | 4567890123456789TH
    +           | 123RD
                | 4567890123456789TH
    -           | 456TH
    +           | <4567890123456789>
     (5 rows)
     
     SELECT '' AS to_char_8,  to_char(q2, 'SG9999999999999999th')   FROM 
INT8_TBL ;
      to_char_8 |       to_char       
     -----------+---------------------
    -           | +             123rd
    -           | -4567890123456789
    +           | +             456th
                | +4567890123456789th
    +           | +             123rd
                | +4567890123456789th
    -           | +             456th
    +           | -4567890123456789
     (5 rows)
     
     SELECT '' AS to_char_9,  to_char(q2, '0999999999999999')       FROM 
INT8_TBL ;
      to_char_9 |      to_char      
     -----------+-------------------
    -           |  0000000000000123
                |  0000000000000456
                |  4567890123456789
    +           |  0000000000000123
                |  4567890123456789
                | -4567890123456789
     (5 rows)
     
     SELECT '' AS to_char_10, to_char(q2, 'S0999999999999999')      FROM 
INT8_TBL ;
      to_char_10 |      to_char      
     ------------+-------------------
    -            | +0000000000000123
                 | +0000000000000456
    -            | -4567890123456789
                 | +4567890123456789
    +            | +0000000000000123
                 | +4567890123456789
    +            | -4567890123456789
     (5 rows)
     
     SELECT '' AS to_char_11, to_char(q2, 'FM0999999999999999')     FROM 
INT8_TBL ;
      to_char_11 |      to_char      
     ------------+-------------------
    -            | 0000000000000123
                 | 0000000000000456
                 | 4567890123456789
    +            | 0000000000000123
                 | 4567890123456789
                 | -4567890123456789
     (5 rows)
     
     SELECT '' AS to_char_12, to_char(q2, 'FM9999999999999999.000') FROM 
INT8_TBL ;
      to_char_12 |        to_char        
     ------------+-----------------------
    -            | 123.000
                 | 456.000
    -            | -4567890123456789.000
                 | 4567890123456789.000
    +            | 123.000
                 | 4567890123456789.000
    +            | -4567890123456789.000
     (5 rows)
     
     SELECT '' AS to_char_13, to_char(q2, 'L9999999999999999.000')  FROM 
INT8_TBL ;
      to_char_13 |        to_char         
     ------------+------------------------
    -            |                123.000
    -            |                456.000
    -            |   4567890123456789.000
    -            |   4567890123456789.000
    -            |  -4567890123456789.000
    +            | $              456.000
    +            | $ 4567890123456789.000
    +            | $              123.000
    +            | $ 4567890123456789.000
    +            | $-4567890123456789.000
    --- End diff --
    
    Why did you add `$` sign here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to