Github user kavinderd commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/796#discussion_r70904822
--- Diff: src/include/access/fileam.h ---
@@ -63,6 +63,17 @@ typedef struct ExternalInsertDescData
typedef ExternalInsertDescData *ExternalInsertDesc;
+/*
+ * ExternalSelectDescData is used for storing state related
+ * to selecting data from an external table.
+ */
+typedef struct ExternalSelectDescData
--- End diff --
That's an option but since we plan on passing other data like the type of
query, etc to PXF I think it will be more maintainable to have this
encapsulating struct so that we don't need to keep changing the method
signatures.
What are your thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
