[ 
https://issues.apache.org/jira/browse/HAWQ-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384622#comment-15384622
 ] 

ASF GitHub Bot commented on HAWQ-927:
-------------------------------------

Github user shivzone commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/796#discussion_r71393037
  
    --- Diff: src/backend/access/external/fileam.c ---
    @@ -454,6 +454,21 @@ external_stopscan(FileScanDesc scan)
        }
     }
     
    +/* ----------------
    + *         external_getnext_init - prepare ExternalSelectDesc struct 
before external_getnext
    +/* ----------------
    + */
    +
    +ExternalSelectDesc
    +external_getnext_init(PlanState *state) {
    +   ExternalSelectDesc desc = (ExternalSelectDesc) 
palloc0(sizeof(ExternalSelectDescData));
    +   if (state != NULL && state->ps_ProjInfo != NULL) {
    +           desc->projInfo = state->ps_ProjInfo;
    --- End diff --
    
    Second check is redundant


> Send Projection Info Data from HAWQ to PXF
> ------------------------------------------
>
>                 Key: HAWQ-927
>                 URL: https://issues.apache.org/jira/browse/HAWQ-927
>             Project: Apache HAWQ
>          Issue Type: Sub-task
>          Components: External Tables, PXF
>            Reporter: Kavinder Dhaliwal
>            Assignee: Kavinder Dhaliwal
>             Fix For: backlog
>
>
> To achieve column projection at the level of PXF or the underlying readers we 
> need to first send this data as a Header/Param to PXF. Currently, PXF has no 
> knowledge whether a query requires all columns or a subset of columns.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to