Github user shivzone commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/803#discussion_r71760909
  
    --- Diff: src/backend/access/external/libchurl.c ---
    @@ -312,6 +312,14 @@ CHURL_HANDLE churl_init_upload(const char* url, 
CHURL_HEADERS headers)
        context->upload = true;
        clear_error_buffer(context);
     
    +   /* needed to resolve pxf service address */
    +   struct curl_slist *resolve_hosts = NULL;
    +   char *pxf_host_entry = (char *) palloc0(strlen(pxf_service_address) + 
strlen(LocalhostIpV4Entry) + 1);
    +   strcat(pxf_host_entry, pxf_service_address);
    --- End diff --
    
    Yes. I was suggesting that we add the below OPT only when 
pxf_service_address is not based on IP address


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to