Github user xunzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/818#discussion_r72386072
  
    --- Diff: src/test/feature/run-feature-test.sh ---
    @@ -0,0 +1,74 @@
    +#! /bin/bash
    +
    +if [ x$GPHOME == 'x' ]; then
    +  echo "Please export GPHOME variable."
    +  exit 0
    +fi
    +
    +init_hawq_test() {
    +  source "${GPHOME}/greenplum_path.sh"
    +  
    +  PSQL=${GPHOME}/bin/psql
    +  TEST_DB_NAME="hawq_feature_test"
    +  
    +  HAWQ_DB=${PGDATABASE:-"postgres"}
    +  HAWQ_HOST=${PGHOST:-"localhost"}
    +  HAWQ_PORT=${PGPORT:-"5432"}
    +
    +  $PSQL -d $HAWQ_DB -h $HAWQ_HOST -p $HAWQ_PORT \
    +        -c "create database $TEST_DB_NAME;" > /dev/null 2>&1
    +  $PSQL -d $HAWQ_DB -h $HAWQ_HOST -p $HAWQ_PORT \
    +        -c "alter database $TEST_DB_NAME set lc_messages to 'C';" > 
/dev/null 2>&1
    +  if [ $? -ne 0 ]; then
    +    echo "Alter database hawq_feature_test set lc_messages failed."
    +    exit 1
    +  fi
    +  $PSQL -d $HAWQ_DB -h $HAWQ_HOST -p $HAWQ_PORT \
    +        -c "alter database $TEST_DB_NAME set lc_monetary to 'C';" > 
/dev/null 2>&1
    +  if [ $? -ne 0 ]; then
    +    echo "Alter database hawq_feature_test set lc_monetary failed."
    +    exit 1
    +  fi
    +  $PSQL -d $HAWQ_DB -h $HAWQ_HOST -p $HAWQ_PORT \
    +        -c "alter database $TEST_DB_NAME set lc_numeric to 'C';" > 
/dev/null 2>&1
    +  if [ $? -ne 0 ]; then
    +    echo "Alter database hawq_feature_test set lc_numeric failed."
    +    exit 1
    +  fi
    +  $PSQL -d $HAWQ_DB -h $HAWQ_HOST -p $HAWQ_PORT \
    +        -c "alter database $TEST_DB_NAME set lc_time to 'C';" > /dev/null 
2>&1
    +  if [ $? -ne 0 ]; then
    +    echo "Alter database hawq_feature_test set lc_time failed."
    +    exit 1
    +  fi
    +  $PSQL -d $HAWQ_DB -h $HAWQ_HOST -p $HAWQ_PORT \
    +        -c "alter database $TEST_DB_NAME set timezone_abbreviations to 
'Default';" > /dev/null 2>&1
    +  if [ $? -ne 0 ]; then
    +    echo "Alter database hawq_feature_test set timezone_abbreviations 
failed."
    +    exit 1
    +  fi
    +  $PSQL -d $HAWQ_DB -h $HAWQ_HOST -p $HAWQ_PORT \
    +        -c "alter database $TEST_DB_NAME set timezone to 'PST8PDT';" > 
/dev/null 2>&1
    +  if [ $? -ne 0 ]; then
    +    echo "Alter database hawq_feature_test set timezone failed."
    +    exit 1
    +  fi
    +  $PSQL -d $HAWQ_DB -h $HAWQ_HOST -p $HAWQ_PORT \
    +        -c "alter database $TEST_DB_NAME set datestyle to 'postgres,MDY';" 
> /dev/null 2>&1
    +  if [ $? -ne 0 ]; then
    +    echo "Alter database hawq_feature_test set datestyle failed."
    +    exit 1
    +  fi
    --- End diff --
    
    Good suggestion! Let me do this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to