Github user xunzhang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/828#discussion_r72934755 --- Diff: src/test/feature/testlib/test_lib.cpp --- @@ -56,6 +58,69 @@ TEST_F(TestCommonLib, TestHawqConfig) { return; } +TEST_F(TestCommonLib, TestHdfsConfig) { + hawq::test::HdfsConfig hc; + hc.isHA(); --- End diff -- As I mentioned in **[REVIEW-LINK-1]**, if you implemented with loading from a configuration file, you should not just invoke the interface. You should load from a test config file and use `EXPECT_EQ`-like macro function to write your tests.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---