Github user wengyanqing commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/828#discussion_r73455316
  
    --- Diff: src/test/feature/lib/hdfs_config.h ---
    @@ -0,0 +1,175 @@
    +#ifndef HAWQ_SRC_TEST_FEATURE_LIB_HDFS_CONFIG_H_
    +#define HAWQ_SRC_TEST_FEATURE_LIB_HDFS_CONFIG_H_
    +
    +#include <string>
    +#include <vector>
    +
    +#include "psql.h"
    +#include "sql_util.h"
    +#include "xml_parser.h"
    +
    +namespace hawq {
    +namespace test {
    +
    +/**
    + * HdfsConfig common libray. Get detailed information about HDFS
    + * including checking state of namenodes and datanodes, get parameter value
    + * @author Chunling Wang
    + */
    +class HdfsConfig {
    --- End diff --
    
    Should HdfsConfig be singleton ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to