Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/895#discussion_r78458628
--- Diff:
pxf/pxf-hive/src/test/java/org/apache/hawq/pxf/plugins/hive/utilities/HiveUtilitiesTest.java
---
@@ -128,47 +128,47 @@ public void mapHiveTypeWithModifiers() throws
Exception {
@Test
public void testCompatibleHiveType() {
- String compatibleTypeName =
HiveUtilities.toCompatibleHiveType(DataType.BOOLEAN);
+ String compatibleTypeName =
HiveUtilities.toCompatibleHiveType(DataType.BOOLEAN, null);
assertEquals(compatibleTypeName,
EnumHiveToHawqType.BooleanType.getTypeName());
- compatibleTypeName =
HiveUtilities.toCompatibleHiveType(DataType.BYTEA);
+ compatibleTypeName =
HiveUtilities.toCompatibleHiveType(DataType.BYTEA, null);
assertEquals(compatibleTypeName,
EnumHiveToHawqType.BinaryType.getTypeName());
- compatibleTypeName =
HiveUtilities.toCompatibleHiveType(DataType.BPCHAR);
+ compatibleTypeName =
HiveUtilities.toCompatibleHiveType(DataType.BPCHAR, null);
assertEquals(compatibleTypeName,
EnumHiveToHawqType.CharType.getTypeName());
- compatibleTypeName =
HiveUtilities.toCompatibleHiveType(DataType.BIGINT);
+ compatibleTypeName =
HiveUtilities.toCompatibleHiveType(DataType.BIGINT, null);
assertEquals(compatibleTypeName,
EnumHiveToHawqType.BigintType.getTypeName());
- compatibleTypeName =
HiveUtilities.toCompatibleHiveType(DataType.SMALLINT);
+ compatibleTypeName =
HiveUtilities.toCompatibleHiveType(DataType.SMALLINT, null);
assertEquals(compatibleTypeName,
EnumHiveToHawqType.SmallintType.getTypeName());
- compatibleTypeName =
HiveUtilities.toCompatibleHiveType(DataType.INTEGER);
+ compatibleTypeName =
HiveUtilities.toCompatibleHiveType(DataType.INTEGER, null);
assertEquals(compatibleTypeName,
EnumHiveToHawqType.IntType.getTypeName());
- compatibleTypeName =
HiveUtilities.toCompatibleHiveType(DataType.TEXT);
+ compatibleTypeName =
HiveUtilities.toCompatibleHiveType(DataType.TEXT, null);
assertEquals(compatibleTypeName,
EnumHiveToHawqType.StringType.getTypeName());
- compatibleTypeName =
HiveUtilities.toCompatibleHiveType(DataType.REAL);
+ compatibleTypeName =
HiveUtilities.toCompatibleHiveType(DataType.REAL, null);
assertEquals(compatibleTypeName,
EnumHiveToHawqType.FloatType.getTypeName());
- compatibleTypeName =
HiveUtilities.toCompatibleHiveType(DataType.FLOAT8);
+ compatibleTypeName =
HiveUtilities.toCompatibleHiveType(DataType.FLOAT8, null);
assertEquals(compatibleTypeName,
EnumHiveToHawqType.DoubleType.getTypeName());
- compatibleTypeName =
HiveUtilities.toCompatibleHiveType(DataType.VARCHAR);
+ compatibleTypeName =
HiveUtilities.toCompatibleHiveType(DataType.VARCHAR, null);
assertEquals(compatibleTypeName,
EnumHiveToHawqType.VarcharType.getTypeName());
- compatibleTypeName =
HiveUtilities.toCompatibleHiveType(DataType.DATE);
+ compatibleTypeName =
HiveUtilities.toCompatibleHiveType(DataType.DATE, null);
assertEquals(compatibleTypeName,
EnumHiveToHawqType.DateType.getTypeName());
- compatibleTypeName =
HiveUtilities.toCompatibleHiveType(DataType.TIMESTAMP);
+ compatibleTypeName =
HiveUtilities.toCompatibleHiveType(DataType.TIMESTAMP, null);
assertEquals(compatibleTypeName,
EnumHiveToHawqType.TimestampType.getTypeName());
- compatibleTypeName =
HiveUtilities.toCompatibleHiveType(DataType.NUMERIC);
+ compatibleTypeName =
HiveUtilities.toCompatibleHiveType(DataType.NUMERIC, null);
--- End diff --
Could you please add tests with not-null modifiers to test getFullTypeName
indirectly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
