Github user xunzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/900#discussion_r78569975
  
    --- Diff: tools/bin/hawqregister ---
    @@ -460,12 +460,13 @@ if __name__ == '__main__':
                     do_not_move, files_update, sizes_update = True, files, 
sizes
                     files, sizes = [], []
             else:
    -            for k, f in enumerate(files):
    +            files_old, sizes_old = [f for f in files], [sz for sz in sizes]
    --- End diff --
    
    Notice here, alternative modification like `files_old, sizes_old = files, 
sizes` is wrong since python default copy is not a deep copy, it is just a 
pointer copy.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to