Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/906#discussion_r83092607
--- Diff:
pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveAccessor.java
---
@@ -205,55 +217,138 @@ private boolean isFiltered(List<HivePartition>
partitionFields,
return testOneFilter(partitionFields, filter, inputData);
}
- /*
- * We are testing one filter against all the partition fields. The
filter
- * has the form "fieldA = valueA". The partitions have the form
- *
partitionOne=valueOne/partitionTwo=ValueTwo/partitionThree=valueThree 1.
- * For a filter to match one of the partitions, lets say partitionA for
- * example, we need: fieldA = partittionOne and valueA = valueOne. If
this
- * condition occurs, we return true. 2. If fieldA does not match any
one of
- * the partition fields we also return true, it means we ignore this
filter
- * because it is not on a partition field. 3. If fieldA =
partittionOne and
- * valueA != valueOne, then we return false.
- */
- private boolean testOneFilter(List<HivePartition> partitionFields,
- Object filter, InputData input) {
- // Let's look first at the filter
- FilterParser.BasicFilter bFilter = (FilterParser.BasicFilter)
filter;
+ private boolean testForUnsupportedOperators(List<Object> filterList) {
--- End diff --
Method name is a bit confusing. Could we rename it to something like
hasUnsupportedOperator?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
