Github user hornn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/972#discussion_r85471780
--- Diff:
pxf/pxf-jdbc/src/main/java/org/apache/hawq/pxf/plugins/jdbc/JdbcPlugin.java ---
@@ -0,0 +1,114 @@
+package org.apache.hawq.pxf.plugins.jdbc;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
+import org.apache.hawq.pxf.api.utilities.InputData;
+import org.apache.hawq.pxf.api.utilities.Plugin;
+
+import java.sql.*;
+
+/**
+ * This class resolves the jdbc connection parameter and manages the
opening and closing of the jdbc connection.
+ * Implemented subclasses: {@link JdbcReadAccessor}.
+ *
+ */
+public class JdbcPlugin extends Plugin {
+ private static final Log LOG = LogFactory.getLog(JdbcPlugin.class);
+
+ //jdbc connection parameters
+ protected String jdbcDriver = null;
+ protected String dbUrl = null;
+ protected String user = null;
+ protected String pass = null;
+ protected String tblName = null;
+ protected int batchSize = 100;
+
+ //jdbc connection
+ protected Connection dbconn = null;
+ //database typeï¼from DatabaseMetaData.getDatabaseProductName()
+ protected String dbProduct = null;
+
+ /**
+ * parse
+ *
+ * @param input the input data
+ */
+ public JdbcPlugin(InputData input) {
+ super(input);
+ jdbcDriver = input.getUserProperty("JDBC_DRIVER");
+ dbUrl = input.getUserProperty("DB_URL");
+ //dbUrl = "jdbc:mysql://192.168.200.6:3306/demodb";
--- End diff --
please remove commented code, or edit to be an example.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
