Github user shivzone commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/981#discussion_r89229211
--- Diff: src/backend/access/external/pxffilters.c ---
@@ -719,6 +1029,143 @@ const_to_str(Const *constval, StringInfo buf)
/*
+ * list_const_to_str
--- End diff --
Please provided extended description of the purpose of this static
function. It is very useful function in the context of our expression handling,
so good to provide description here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
