Github user shivzone commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1021#discussion_r89234431
  
    --- Diff: 
pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/FilterParser.java ---
    @@ -418,6 +430,40 @@ private Object parseParameter() throws Exception {
             return data;
         }
     
    +    private Object parseListParameter() throws Exception {
    +        if (index == filterByteArr.length) {
    +            throw new FilterStringSyntaxException("argument should follow 
at " + index);
    +        }
    +
    +        DataType dataType = DataType.get(parseConstDataType());
    +        List<Object> data = new ArrayList<Object>();
    +        if (dataType == DataType.UNSUPPORTED_TYPE) {
    +            throw new FilterStringSyntaxException("invalid DataType OID at 
" + (index - 1));
    +        }
    +
    +        if (dataType.getTypeElem() == null) {
    +            throw new FilterStringSyntaxException("expected non-scalar 
datatype, but got datatype with oid = " + dataType.getOID());
    +        }
    +
    +        while (((char) filterByteArr[index]) == CONST_LEN) {
    +            int dataLength = parseDataLength();
    --- End diff --
    
    What happens in query scenarios with column in [''] or column in []


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to