Github user xunzhang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1036#discussion_r90880247
--- Diff: src/backend/resourcemanager/include/utils/simplestring.h ---
@@ -63,7 +63,7 @@ bool SimpleStringEmpty(SimpStringPtr str);
int SimpleStringLocateChar(SimpStringPtr str, char target, int *location);
/* string to the other number values. */
int SimpleStringToInt32(SimpStringPtr str, int32_t *value);
-int SimpleStringToInt64(SimpStringPtr str, int64_t *value);
+int SimpleStringToInt64(SimpStringPtr str, int64 *value);
--- End diff --
Because the definition of `int64` is `long int` while the definition of
`int64_t` is `long long int`. Besides, the caller of this function is a
`HostnameVolumeInfo` object which is definited as a `int64`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
