Github user interma commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1072#discussion_r94204047
--- Diff: src/include/utils/rangerrest.h ---
@@ -86,10 +90,9 @@ typedef struct RangerRequestJsonArgs {
} RangerRequestJsonArgs;
RangerACLResult parse_ranger_response(char *);
-json_object *create_ranger_request_json_batch(List *);
-json_object *create_ranger_request_json(char *, AclObjectKind kind, char
*, List *, bool);
+json_object *create_ranger_request_json(List *);
int call_ranger_rest(CURL_HANDLE curl_handle, const char *request);
-extern int check_privilege_from_ranger_batch(List *);
-extern int check_privilege_from_ranger(char *, AclObjectKind kind, char *,
List *, bool);
+extern int check_privilege_from_ranger(List *);
+void getClientIP(char *remote_host);
--- End diff --
Since we do not call *getClientIP()* in the outside, it seems better to
make it private in rangerrest.c?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
