Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1074#discussion_r94894709
--- Diff: src/backend/catalog/aclchk.c ---
@@ -3006,8 +3007,8 @@ pg_database_aclmask(Oid db_oid, Oid roleid,
Oid ownerId;
cqContext *pcqCtx;
- /* Superusers or on QE bypass all permission checking. */
- if (GP_ROLE_EXECUTE == Gp_role || superuser_arg(roleid))
--- End diff --
By the way, I know many people like to write "GP_ROLE_EXECUTE == Gp_role"
similar code to avoid typo like "GP_role = GP_ROLE_EXECUTE" but gcc will warn
against this kind of error.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
