Github user edespino commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1124#discussion_r101207986
--- Diff: pom.xml ---
@@ -129,39 +129,88 @@
<exclude>src/pl/**/*</exclude>
<exclude>src/port/*</exclude>
<exclude>src/template/*</exclude>
- <exclude>src/test/**/*.in</exclude>
- <exclude>src/test/**/*.mdp</exclude>
+
+ <!-- src/test/bench -->
+
+ <exclude>src/test/bench/query*</exclude>
+
+ <!-- PostgreSQL src/test/regress -->
+
+ <exclude>src/test/regress/**/*.in</exclude>
+ <exclude>src/test/regress/**/*.mdp</exclude>
+ <exclude>src/test/regress/**/*.xml</exclude>
+
<exclude>src/test/regress/data/fixedwidth/fixedwidth_3chars_line_delimiter.tbl</exclude>
+
<exclude>src/test/regress/data/fixedwidth/fixedwidth_big.tbl</exclude>
+
<exclude>src/test/regress/data/fixedwidth/fixedwidth_no_line_delimiter.tbl</exclude>
+
<exclude>src/test/regress/data/fixedwidth/fixedwidth_out.tbl</exclude>
+
<exclude>src/test/regress/data/fixedwidth/fixedwidth_small_blankfields.tbl</exclude>
+
<exclude>src/test/regress/data/fixedwidth/fixedwidth_small_blankfields_and_nulls.tbl</exclude>
+
<exclude>src/test/regress/data/fixedwidth/fixedwidth_small_correct.tbl</exclude>
+
<exclude>src/test/regress/data/fixedwidth/fixedwidth_small_error_fieldtoolong.tbl</exclude>
+
<exclude>src/test/regress/data/fixedwidth/fixedwidth_small_error_fieldtype.tbl</exclude>
+
<exclude>src/test/regress/data/fixedwidth/fixedwidth_small_error_rejectlimitcrossed.tbl</exclude>
+
<exclude>src/test/regress/data/fixedwidth/fixedwidth_small_error_rejectlimitnotcrossed.tbl</exclude>
+
<exclude>src/test/regress/data/fixedwidth/fixedwidth_small_error_toofewfields.tbl</exclude>
+
<exclude>src/test/regress/data/fixedwidth/fixedwidth_small_error_toomanyfields.tbl</exclude>
+
<exclude>src/test/regress/data/fixedwidth/fixedwidth_small_nulldefined.tbl</exclude>
+ <exclude>src/test/regress/data/nation.tbl</exclude>
+ <exclude>src/test/regress/data/nation_error50.tbl</exclude>
+ <exclude>src/test/regress/data/region.tbl</exclude>
+ <exclude>src/test/regress/expected_statuses</exclude>
+
+ <!-- src/test/feature -->
+
+
<exclude>src/test/feature/ExternalSource/data/nation.tbl</exclude>
+
<exclude>src/test/feature/ExternalSource/data/nation_error50.tbl</exclude>
+
<exclude>src/test/feature/ExternalSource/data/region.tbl</exclude>
+
<exclude>src/test/feature/ManagementTool/test_hawq_register_hawq.paq</exclude>
+
<exclude>src/test/feature/ManagementTool/test_hawq_register_hive.paq</exclude>
+
<exclude>src/test/feature/ManagementTool/data/parquet200/dat.paq</exclude>
+
<exclude>src/test/feature/ManagementTool/data/parquet200sum/a.paq</exclude>
+
<exclude>src/test/feature/ManagementTool/data/parquet200sum/b.paq</exclude>
+
<exclude>src/test/feature/ManagementTool/test_hawq_register_data_types.paq</exclude>
--- End diff --
I'm afraid we will not question files which do not have ASF headers if we
use directory wild cards so freely. As an example, the following was excluded
but should have had a header:
<exclude>src/test/**/init_file</exclude>
Thank you for helping us think through this. It helps us all in the end.
For now, I would like to be explicit in our exclusions. We can revisit if it
becomes a significant maintenance issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
