Github user wcl14 commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1152#discussion_r103395505
  
    --- Diff: src/backend/catalog/namespace.c ---
    @@ -1982,6 +1982,13 @@ recomputeNamespacePath(void)
                        elog(DEBUG3, "recompute search_path[%s] when acl_type 
is ranger", namespace_search_path);
                }
        }
    +   else 
    +   {
    +           if (aclType == HAWQ_ACL_RANGER && debug_query_string != NULL)
    +           {
    +                   last_query_sign = string_hash(debug_query_string, 
strlen(debug_query_string));
    +           }
    +   }
    --- End diff --
    
    How about set current_qurey_sign before the if statement 'if 
(namespaceSearchPathValid && namespaceUser == roleid)' and set last_query_sign 
after the if statement? Can this make the return condition more clear?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to