Github user shivzone commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1179#discussion_r107220629
  
    --- Diff: pxf/Makefile ---
    @@ -42,6 +42,10 @@ ifneq "$(PXF_VERSION)" ""
         BUILD_PARAMS+= -Pversion="$(PXF_VERSION)"
     endif
     
    +ifneq "$(GRADLEW_OPTIONS)" ""
    --- End diff --
    
    The purpose of Makefile is to abstract the user from gradle 
options/commands. Should we instead call this BUILD_OPTIONS ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to