Github user stanlyxiang commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1235#discussion_r115424467
  
    --- Diff: tools/bin/hawq_ctl ---
    @@ -387,6 +387,10 @@ class HawqInit:
                      (self.GPHOME, self.standby_host_name, self.GPHOME)
             check_return_code(remote_ssh(scpcmd, self.master_host_name, 
self.user), \
                               logger, "Sync slaves file failed")
    +        scpcmd = "scp %s/ranger/etc/* %s:%s/ranger/etc/ > /dev/null" % \
    +                 (self.GPHOME, self.standby_host_name, self.GPHOME)
    +        check_return_code(remote_ssh(scpcmd, self.master_host_name, 
self.user), \
    +                          logger, "Sync rps configuration files failed")
    --- End diff --
    
    This code snippet is used for copy ranger configuration files to standby 
when do "hawq init standby" when ranger was configured.  But there maybe no 
ranger.  Standalone case will fail.
    e.g. When hawq init cluster(it will init standby), hawq is absolutely not 
configured with ranger. If there is a cluster with hawq master and segment 
configured with ranger, then we should scp rps configuration files to standby 
when "hawq init standby".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to