Github user denalex commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1225#discussion_r118129209
  
    --- Diff: 
pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/utilities/Utilities.java ---
    @@ -234,4 +235,15 @@ public static boolean useStats(ReadAccessor accessor, 
InputData inputData) {
                 return false;
             }
         }
    +
    +    public static boolean useVectorization(InputData inputData) {
    +        boolean isVectorizedResolver = false;
    +        try {
    +            isVectorizedResolver = 
ArrayUtils.contains(Class.forName(inputData.getResolver()).getInterfaces(), 
ReadVectorizedResolver.class);
    +        } catch (ClassNotFoundException e) {
    +            LOG.error("Unable to load resolver class: " + e.getMessage());
    +            return false;
    --- End diff --
    
    no need for this line, it will return at the end of the function with 
default false value.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to