Github user denalex commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1249#discussion_r119739575 --- Diff: pxf/pxf-jdbc/src/test/java/org/apache/hawq/pxf/plugins/jdbc/JdbcPartitionFragmenterTest.java --- @@ -164,8 +163,8 @@ public void inValidParameterFormat() throws Exception { when(inputData.getUserProperty("RANGE")).thenReturn("100:200"); try { new JdbcPartitionFragmenter(inputData); - fail("Expected an ArrayIndexOutOfBoundsException"); - } catch (ArrayIndexOutOfBoundsException ex) { + fail("Expected an UserDataException"); --- End diff -- use @Test(expected = UserDataException.class) so that there is no need for try / catch / fail lines : https://github.com/junit-team/junit4/wiki/exception-testing
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---