GitHub user denalex opened a pull request:
https://github.com/apache/incubator-hawq/pull/1303
HAWQ-1540. PXF should not accept parameters for init command
Currently PXF accepts --hadoop-home parameter for init command, which is
used in greenplum-embedded deployment to specify where Hadoop client artifacts
are installed. The desired behavior is:
* do not accept any parameters during init command
* rely on configuration provided by conf/pxf-env.sh file
* introduce new HADOOP_DISTRO variable that can take the following values:
[<empty>, HDP, CDH, CUSTOM]
* when the value is empty â the script will check for existence of
RPM-installed HDP hadoop-client in /usr/hdp/current/hadoop-client/client and if
found, will use HDP-specific private classpath template to generate new
pxf-private.classpath file. If not found, the script will check for existence
of RPM-installed CDH hadoop-client in /usr/lib/hadoop/client and if found, will
use CDH-specific private classpath template to generate new
pxf-private.classpath file. If none were found, the script will check for a
TAR-installed hadoop client in the directory specified by the new variable
HADOOP_ROOT under $ {HADOOP_ROOT}/hadoop/share/hadoop/common/lib. If found, the
script will use TAR-specific private classpath template to generate new
pxf-private.classpath file. That template assumes Hadoop client (and optionally
Hive and HBase clients) are installed under a common directorythat is pointed
to by HADOOP_ROOT variable. A user will have to specify this variable or edit
the pxf-env.sh c
onfig file before attempting pxf init command. If HADOOP_ROOT is not set of
${HADOOP_ROOT}
/hadoop/share/hadoop/common/lib directory does not exist, the script will
error out.
* when the value is HDP â the script will check for existence of
RPM-installed HDP hadoop-client in /usr/hdp/current/hadoop-client/client and if
found, will use HDP-specific private classpath template to generate new
pxf-private.classpath file. If not found, the script will check for
TAR-installed distribution as described above.
* when the value is CDH â the script will check for existence of
RPM-installed CDH hadoop-client in /usr/lib/hadoop/client and if found, will
use CDH-specific private classpath template to generate new
pxf-private.classpath file. If not found, the script will check for
TAR-installed distribution as described above.
* when the value is CUSTOM â the script will check for TAR-installed
distribution as described above, except it will not error out if HADOOP_ROOT is
not set or points to a non-existing directory. If HADOOP_ROOT is set, the value
will be substituted in tar-based template, even if the directory does not yet
exist. If HADOOP_ROOT is not set, the tar-based template is copied to the
conf/pxf-private.classpath file and the user will have to perform the editing
of this file.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/denalex/incubator-hawq pxf-rpm
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1303.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1303
----
commit 3bf9690ef1bb0d854cdaf02b51c7d676d90bd18e
Author: Alexander Denissov <adenis...@pivotal.io>
Date: 2017-10-18T20:57:03Z
removed options from pxf init command
commit 7014c312e53ca0de70634f50f9ef583306fdf4b3
Author: Alexander Denissov <adenis...@pivotal.io>
Date: 2017-10-18T23:31:20Z
added hadoopDistro to install task
commit 6bff61ee7232119becbec6e82423a3b8598aec6c
Author: Alexander Denissov <adenis...@pivotal.io>
Date: 2017-10-18T23:46:46Z
added comments to the template
commit c17ef7a30bf830ee5d1c01f0168ba6c3c7a038e7
Author: Alexander Denissov <adenis...@pivotal.io>
Date: 2017-10-19T00:03:29Z
fixed exit statement
commit 056f92745965aa59bf68387137bc0a7f823e7935
Author: Alexander Denissov <adenis...@pivotal.io>
Date: 2017-10-20T17:39:17Z
refactored for HADOOP_ROOT
commit 1127c3f53331af24eb27f889f926c9d84a621ed0
Author: Alexander Denissov <adenis...@pivotal.io>
Date: 2017-10-20T18:03:33Z
fixed build.gradle
commit cd50420e6c53654b11eae96a3cdbae17ecba673e
Author: Alexander Denissov <adenis...@pivotal.io>
Date: 2017-10-20T18:45:59Z
added additional jar for hbase
commit f9478e2eb1f72da038d43a468b11757a4f2592be
Author: Alexander Denissov <adenis...@pivotal.io>
Date: 2017-10-21T00:33:19Z
added htrace-core.jar from hbase
commit 6dffc018cd073d759ebdb04eefba8d60ed65ee0b
Author: Alexander Denissov <adenis...@pivotal.io>
Date: 2017-10-23T17:23:55Z
changed log level to info
commit 0d98fcba4897b2af9ae94e3e5bd3ae07763ee261
Author: Alexander Denissov <adenis...@pivotal.io>
Date: 2017-10-23T17:44:35Z
updated message
commit 918eba6b0a99454b993f13bb3000c66ab0de015f
Author: Alexander Denissov <adenis...@pivotal.io>
Date: 2017-10-23T17:53:10Z
updated message
----
---
