Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1379#discussion_r202119803
--- Diff:
pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/UGICache.java ---
@@ -129,90 +135,93 @@ public void release(Entry timedProxyUGI, boolean
forceClean) {
}
/**
- * Iterate through all the entries in the queue for the given segment
+ * Iterate through all the entries in the queue for the given
session's segment
* and close expired {@link UserGroupInformation}, otherwise it resets
* the timer for every non-expired entry.
*
- * @param segmentId
+ * @param session
*/
- private void cleanup(Integer segmentId) {
+ private void cleanup(SessionId session) {
--- End diff --
The cleanup here is confusing because it is using the current session with
any expired UGI
---
