[
https://issues.apache.org/jira/browse/HBASE-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876812#action_12876812
]
HBase Review Board commented on HBASE-2684:
-------------------------------------------
Message from: "Jean-Daniel Cryans" <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/163/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
Patch that uses MiniHBaseCluster.waitOnRegionServer instead of sleeping, and
adds a timeout to the test.
This addresses bug HBASE-2684.
Diffs
-----
/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterWrongRS.java
952744
Diff: http://review.hbase.org/r/163/diff
Testing
-------
Thanks,
Jean-Daniel
> TestMasterWrongRS flaky in trunk
> --------------------------------
>
> Key: HBASE-2684
> URL: https://issues.apache.org/jira/browse/HBASE-2684
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.21.0
> Reporter: Todd Lipcon
> Assignee: Jean-Daniel Cryans
>
> I think this is just a flaky test. I saw:
> java.lang.AssertionError: expected:<2> but was:<3>
> on the first:
> assertEquals(2, cluster.getLiveRegionServerThreads().size());
> My guess is that the 2 second sleep is not good enough. We should probably
> either force a heartbeat somehow, or hook in so we can wait until there's
> been a heartbeat, rather than sleeping a hardcoded amount of time.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
