[ 
https://issues.apache.org/jira/browse/HBASE-2656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12880924#action_12880924
 ] 

HBase Review Board commented on HBASE-2656:
-------------------------------------------

Message from: "Todd Lipcon" <[email protected]>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/214/
-----------------------------------------------------------

Review request for hbase and stack.


Summary
-------

Would be good to get these things out of HMaster entirely to share code with 
other META lookup stuff, but here's a first pass cleanup.


This addresses bug HBASE-2656.
    http://issues.apache.org/jira/browse/HBASE-2656


Diffs
-----

  src/main/java/org/apache/hadoop/hbase/HRegionInfo.java d6f9611 
  src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 4c0f392 
  src/main/java/org/apache/hadoop/hbase/master/HMaster.java 66dc697 
  src/test/java/org/apache/hadoop/hbase/master/TestMaster.java a5f4d69 

Diff: http://review.hbase.org/r/214/diff


Testing
-------


Thanks,

Todd




> HMaster.getRegionTableClosest should not return null for closed regions
> -----------------------------------------------------------------------
>
>                 Key: HBASE-2656
>                 URL: https://issues.apache.org/jira/browse/HBASE-2656
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 0.21.0
>            Reporter: Todd Lipcon
>            Priority: Blocker
>         Attachments: hbase-2656.txt
>
>
> Raised in the review of HBASE-2560: there are a couple functions in HMaster 
> which return null when a region has not been deployed. Instead, they should 
> return a Pair<HRegionInfo, HServerAddress> where only the address is null 
> (since the info is still in meta!)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to