[ 
https://issues.apache.org/jira/browse/HBASE-2696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Gray updated HBASE-2696:
---------------------------------

    Attachment: HBASE-2696-part1-NewClasses_NotIntegrated.patch

First patch of ZK cleanup.  I wanted to cut a patch and get this committed 
before I really rip stuff up.  This patch does not yet touch the existing 
ZooKeeperWrapper.

* Adds three new classes that will mostly replace current {{ZooKeeperWrapper}}:
** *{{ZooKeeperWatcher}}* acts as the single watcher for a process and also 
holds the ZooKeeper connection itself (instantiated class, no longer singleton 
like ZKWrapper).  All ZK connection events are handled in here, normal events 
are passed along to any registered {{ZooKeeperListeners}}.
** *{{ZooKeeperListener}}* is a base class that acts as hbase-internal ZK 
Watchers.  Consumers of ZK events will extend the class and override any of the 
events they are interested in.
** *{{ZKUtil}}* will contain static methods that actually do things like 
read/write znodes, list children, etc... These methods will take a 
{{ZooKeeperWatcher}}.
* Breaks out parts of {{HQuorumPeer}} into new {{ZKConfig}} class that just 
deals with the parsing of stuff


> ZooKeeper cleanup and refactor
> ------------------------------
>
>                 Key: HBASE-2696
>                 URL: https://issues.apache.org/jira/browse/HBASE-2696
>             Project: HBase
>          Issue Type: Sub-task
>          Components: master, regionserver, zookeeper
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>            Priority: Critical
>             Fix For: 0.21.0
>
>         Attachments: HBASE-2696-part1-NewClasses_NotIntegrated.patch
>
>
> Currently almost everything we do with ZooKeeper is stuffed into a single 
> class {{ZookeeperWrapper}}.
> This issue will deal with cleaning up our usage of ZK, adding some new 
> abstractions to help with the master changes, splitting up watchers from 
> utility methods, and nailing down the contracts of our ZK methods with 
> respect to setting watchers, throwing exceptions, etc...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to