[ https://issues.apache.org/jira/browse/HBASE-2794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887501#action_12887501 ]
HBase Review Board commented on HBASE-2794: ------------------------------------------- Message from: "Kannan Muthukkaruppan" <kan...@facebook.com> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/296/#review361 ----------------------------------------------------------- /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java <http://review.hbase.org/r/296/#comment1497> can't this loop be over "columns" itself? And then inside the loop, you prepare one key at a time use Bytes.add(row, col). That way, you can avoid the keyList data structure completely. - Kannan > ROWCOL bloom filter not used if multiple columns within same family are > requested in a Get > ------------------------------------------------------------------------------------------ > > Key: HBASE-2794 > URL: https://issues.apache.org/jira/browse/HBASE-2794 > Project: HBase > Issue Type: Improvement > Reporter: Kannan Muthukkaruppan > Attachments: 2794_multi_column_check.txt > > > Noticed the following snippet in StoreFile.java:Scanner:shouldSeek(): > {code} > switch(bloomFilterType) { > case ROW: > key = row; > break; > case ROWCOL: > if (columns.size() == 1) { > byte[] col = columns.first(); > key = Bytes.add(row, col); > break; > } > //$FALL-THROUGH$ > default: > return true; > } > {code} > If columns.size > 1, then we currently don't take advantage of the bloom > filter. We should optimize this to check bloom for each of columns and if > none of the columns are present in the bloom avoid opening the file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.