[
https://issues.apache.org/jira/browse/HBASE-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887497#action_12887497
]
HBase Review Board commented on HBASE-2265:
-------------------------------------------
Message from: "Ryan Rawson" <ryano...@gmail.com>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/257/#review357
-----------------------------------------------------------
there are a number of intenting issues, HBase uses a 2 space base and a 4 space
hanging indent standard. Also we space separate the outside of our braces, so
it is "if (" not "if(". The interior of the braces are not to be spaced, eg:
"(foo)" not "( foo )". I am also seeing a large number of trailing whitespace,
you should be able to set your editor to automatically remove that for you.
They show up as red blocks on the code review.
It also appears that this patch includes pieces from other bloom related
patches... those code snippets should be removed from this patch.
trunk/src/main/java/org/apache/hadoop/hbase/KeyValue.java
<http://review.hbase.org/r/257/#comment1483>
This doesnt appear to be germane to the issue at hand. It shouldn't appear
in this patch.
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java
<http://review.hbase.org/r/257/#comment1489>
indentation, looks like there might be a tab here
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
<http://review.hbase.org/r/257/#comment1492>
is this idiomatic? I dont think I've seen this particular pattern before?
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
<http://review.hbase.org/r/257/#comment1496>
This doesnt seem germane to the issue at hand... Can we not do this here?
- Ryan
> HFile and Memstore should maintain minimum and maximum timestamps
> -----------------------------------------------------------------
>
> Key: HBASE-2265
> URL: https://issues.apache.org/jira/browse/HBASE-2265
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Reporter: Todd Lipcon
> Assignee: Pranav Khaitan
>
> In order to fix HBASE-1485 and HBASE-29, it would be very helpful to have
> HFile and Memstore track their maximum and minimum timestamps. This has the
> following nice properties:
> - for a straight Get, if an entry has been already been found with timestamp
> X, and X >= HFile.maxTimestamp, the HFile doesn't need to be checked. Thus,
> the current fast behavior of get can be maintained for those who use strictly
> increasing timestamps, but "correct" behavior for those who sometimes write
> out-of-order.
> - for a scan, the "latest timestamp" of the storage can be used to decide
> which cell wins, even if the timestamp of the cells is equal. In essence,
> rather than comparing timestamps, instead you are able to compare tuples of
> (row timestamp, storage.max_timestamp)
> - in general, min_timestamp(storage A) >= max_timestamp(storage B) if storage
> A was flushed after storage B.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
