[
https://issues.apache.org/jira/browse/HBASE-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909516#action_12909516
]
HBase Review Board commented on HBASE-2997:
-------------------------------------------
Message from: "Todd Lipcon" <t...@cloudera.com>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/845/#review1204
-----------------------------------------------------------
Ship it!
Looks like a fine refactor, but how does this change performance?
src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java
<http://review.cloudera.org/r/845/#comment4115>
do we need these anymore?
src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java
<http://review.cloudera.org/r/845/#comment4114>
can you just call through to initMethods() here?
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
<http://review.cloudera.org/r/845/#comment4112>
random junk
- Todd
> Performance fixes - profiler driven
> -----------------------------------
>
> Key: HBASE-2997
> URL: https://issues.apache.org/jira/browse/HBASE-2997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.89.20100621
> Reporter: ryan rawson
> Assignee: ryan rawson
> Priority: Critical
> Fix For: 0.90.0
>
> Attachments: HBASE-2997-1.txt, HBASE-2997-2.txt, HBASE-2997-3.txt,
> HBASE-2997-4.txt, HBASE-2997-5.txt
>
>
> while profiling hbase I found a number of slow pieces. Here are fixes for
> them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
