[ 
https://issues.apache.org/jira/browse/HBASE-3053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916354#action_12916354
 ] 

HBase Review Board commented on HBASE-3053:
-------------------------------------------

Message from: "Jonathan Gray" <[email protected]>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/925/#review1361
-----------------------------------------------------------


Ah, well the blocking happens in the constructor, so the test launcher just 
sticks on the first master which blocks in the constructor.

Could we move everything from the constructor into run()?  At least the stuff 
that blocks / after the blocking (which is almost everything)?

- Jonathan





> Add ability to have multiple Masters LocalHBaseCluster for test writing
> -----------------------------------------------------------------------
>
>                 Key: HBASE-3053
>                 URL: https://issues.apache.org/jira/browse/HBASE-3053
>             Project: HBase
>          Issue Type: Improvement
>          Components: master, test
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>             Fix For: 0.90.0
>
>
> To really be able to unit test the new master properly, we need to be able to 
> have multiple masters running at once within a single logical cluster.
> Should expose some methods like getActiveMaster() and isActiveMaster() as 
> well as a simple way to kill an individual master / kill the active master.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to