[
https://issues.apache.org/jira/browse/HBASE-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917301#action_12917301
]
HBase Review Board commented on HBASE-2001:
-------------------------------------------
Message from: "Lars Francke" <lars.fran...@gmail.com>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/876/#review1380
-----------------------------------------------------------
Sorry for all the whitespace comments :)
There are a bunch more in the test classes.
src/main/java/org/apache/hadoop/hbase/HServerInfo.java
<http://review.cloudera.org/r/876/#comment4581>
The ternary operator does not need braces.
src/main/java/org/apache/hadoop/hbase/client/Action.java
<http://review.cloudera.org/r/876/#comment4582>
The ternary operator does not need braces.
src/main/java/org/apache/hadoop/hbase/client/Batch.java
<http://review.cloudera.org/r/876/#comment4583>
Remove extra character(s)
src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
<http://review.cloudera.org/r/876/#comment4586>
Should be of Type List<R> not ArrayList<R>
src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
<http://review.cloudera.org/r/876/#comment4585>
Why is this necessary? You already set the size by using the correct
constructor.
src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java
<http://review.cloudera.org/r/876/#comment4588>
Remove the "public", interfaces don't need that.
src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java
<http://review.cloudera.org/r/876/#comment4589>
Remove the "public", interfaces don't need that.
Also byte[] key in Map so every implementor has to make sure to use a Map
that does this correctly.
src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java
<http://review.cloudera.org/r/876/#comment4590>
Remove the "public", interfaces don't need that.
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseCommandTarget.java
<http://review.cloudera.org/r/876/#comment4591>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseCommandTarget.java
<http://review.cloudera.org/r/876/#comment4592>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseCommandTarget.java
<http://review.cloudera.org/r/876/#comment4593>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
<http://review.cloudera.org/r/876/#comment4594>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
<http://review.cloudera.org/r/876/#comment4595>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
<http://review.cloudera.org/r/876/#comment4596>
Inconsistent formatting
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
<http://review.cloudera.org/r/876/#comment4597>
Inconsistent formatting
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
<http://review.cloudera.org/r/876/#comment4598>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
<http://review.cloudera.org/r/876/#comment4599>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
<http://review.cloudera.org/r/876/#comment4600>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
<http://review.cloudera.org/r/876/#comment4601>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
<http://review.cloudera.org/r/876/#comment4602>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
<http://review.cloudera.org/r/876/#comment4603>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
<http://review.cloudera.org/r/876/#comment4604>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
<http://review.cloudera.org/r/876/#comment4605>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<http://review.cloudera.org/r/876/#comment4612>
Remove public static final
src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<http://review.cloudera.org/r/876/#comment4606>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<http://review.cloudera.org/r/876/#comment4613>
Remove public
src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<http://review.cloudera.org/r/876/#comment4614>
Remove public
src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<http://review.cloudera.org/r/876/#comment4615>
Remove public
src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<http://review.cloudera.org/r/876/#comment4607>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<http://review.cloudera.org/r/876/#comment4616>
Remove public
src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<http://review.cloudera.org/r/876/#comment4617>
Remove public
src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<http://review.cloudera.org/r/876/#comment4608>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<http://review.cloudera.org/r/876/#comment4618>
Remove public
src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<http://review.cloudera.org/r/876/#comment4609>
Whitespace stuff
Remove public
src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<http://review.cloudera.org/r/876/#comment4610>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<http://review.cloudera.org/r/876/#comment4619>
Remove public
src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<http://review.cloudera.org/r/876/#comment4611>
Whitespace stuff
Remove public
src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<http://review.cloudera.org/r/876/#comment4620>
Remove public
src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<http://review.cloudera.org/r/876/#comment4621>
Remove public
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java
<http://review.cloudera.org/r/876/#comment4622>
Remove public
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java
<http://review.cloudera.org/r/876/#comment4623>
Remove public
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java
<http://review.cloudera.org/r/876/#comment4624>
Remove public
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java
<http://review.cloudera.org/r/876/#comment4625>
Remove public
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java
<http://review.cloudera.org/r/876/#comment4626>
Remove public
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java
<http://review.cloudera.org/r/876/#comment4627>
Remove public
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java
<http://review.cloudera.org/r/876/#comment4628>
Remove public
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java
<http://review.cloudera.org/r/876/#comment4629>
Remove public
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorException.java
<http://review.cloudera.org/r/876/#comment4630>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorException.java
<http://review.cloudera.org/r/876/#comment4631>
Remove extra space behind the brace
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
<http://review.cloudera.org/r/876/#comment4642>
Remove "public"
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
<http://review.cloudera.org/r/876/#comment4632>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
<http://review.cloudera.org/r/876/#comment4643>
Remove "public"
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
<http://review.cloudera.org/r/876/#comment4644>
Remove "public"
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
<http://review.cloudera.org/r/876/#comment4645>
Remove "public"
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
<http://review.cloudera.org/r/876/#comment4633>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
<http://review.cloudera.org/r/876/#comment4646>
Remove "public"
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
<http://review.cloudera.org/r/876/#comment4634>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
<http://review.cloudera.org/r/876/#comment4647>
Remove "public"
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
<http://review.cloudera.org/r/876/#comment4648>
Remove "public"
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
<http://review.cloudera.org/r/876/#comment4649>
Remove "public"
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
<http://review.cloudera.org/r/876/#comment4635>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
<http://review.cloudera.org/r/876/#comment4650>
Remove "public"
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
<http://review.cloudera.org/r/876/#comment4651>
Remove "public"
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
<http://review.cloudera.org/r/876/#comment4636>
Whitespace stuff
Remove "public"
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
<http://review.cloudera.org/r/876/#comment4637>
Whitespace stuff
Remove "public"
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
<http://review.cloudera.org/r/876/#comment4638>
Whitespace stuff
Remove "public"
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
<http://review.cloudera.org/r/876/#comment4639>
Whitespace stuff
Remove "public"
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
<http://review.cloudera.org/r/876/#comment4652>
Remove "public"
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
<http://review.cloudera.org/r/876/#comment4653>
Remove "public"
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
<http://review.cloudera.org/r/876/#comment4654>
Remove "public"
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
<http://review.cloudera.org/r/876/#comment4655>
Remove "public"
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
<http://review.cloudera.org/r/876/#comment4656>
Remove "public"
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
<http://review.cloudera.org/r/876/#comment4640>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
<http://review.cloudera.org/r/876/#comment4657>
Remove "public"
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
<http://review.cloudera.org/r/876/#comment4658>
Remove "public"
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
<http://review.cloudera.org/r/876/#comment4641>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
<http://review.cloudera.org/r/876/#comment4659>
Remove "public"
src/main/java/org/apache/hadoop/hbase/coprocessor/package-info.java
<http://review.cloudera.org/r/876/#comment4707>
Lots of whitespace stuff in this file. I've not listed them all.
src/main/java/org/apache/hadoop/hbase/ipc/ConnectionHeader.java
<http://review.cloudera.org/r/876/#comment4708>
public Log?
src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java
<http://review.cloudera.org/r/876/#comment4709>
private static final
src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java
<http://review.cloudera.org/r/876/#comment4710>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
<http://review.cloudera.org/r/876/#comment4711>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
<http://review.cloudera.org/r/876/#comment4712>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java
<http://review.cloudera.org/r/876/#comment4713>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/ipc/SecureClient.java
<http://review.cloudera.org/r/876/#comment4714>
Wrong formatting
src/main/java/org/apache/hadoop/hbase/ipc/SecureServer.java
<http://review.cloudera.org/r/876/#comment4715>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/ipc/Status.java
<http://review.cloudera.org/r/876/#comment4716>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
<http://review.cloudera.org/r/876/#comment4717>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
<http://review.cloudera.org/r/876/#comment4718>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
<http://review.cloudera.org/r/876/#comment4719>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
<http://review.cloudera.org/r/876/#comment4720>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
<http://review.cloudera.org/r/876/#comment4721>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
<http://review.cloudera.org/r/876/#comment4722>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
<http://review.cloudera.org/r/876/#comment4723>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4724>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4725>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4726>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4727>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4728>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4729>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4730>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4731>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4732>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4733>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4734>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4735>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4736>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4739>
Lock should be acquired before the try block
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4737>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4740>
Lock should be acquired before the try block
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4741>
Lock should be acquired before the try block
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4742>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4743>
Lock should be acquired before the try block
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4745>
Lock should be acquired before the try block
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4744>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4746>
Lock should be acquired before the try block
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4747>
Lock should be acquired before the try block
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4748>
Lock should be acquired before the try block
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4749>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4750>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4751>
Lock should be acquired before the try block
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4752>
Lock should be acquired before the try block
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4753>
Lock should be acquired before the try block
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4754>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4755>
Lock should be acquired before the try block
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4756>
Lock should be acquired before the try block
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4757>
Lock should be acquired before the try block
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4758>
Lock should be acquired before the try block
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4759>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4761>
Inconsistent indentation with most of the rest of the file
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4760>
Lock should be acquired before the try block
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4762>
Lock should be acquired before the try block
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4763>
Lock should be acquired before the try block
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4764>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4765>
Lock should be acquired before the try block
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4766>
Lock should be acquired before the try block
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4768>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4767>
Lock should be acquired before the try block
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4770>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4771>
Lock should be acquired before the try block
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4773>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4772>
Lock should be acquired before the try block
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4774>
Lock should be acquired before the try block
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4775>
Lock should be acquired before the try block
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4776>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4777>
Lock should be acquired before the try block
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4778>
Lock should be acquired before the try block
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4779>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4780>
Lock should be acquired before the try block
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4781>
Lock should be acquired before the try block
src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java
<http://review.cloudera.org/r/876/#comment4782>
Lock should be acquired before the try block
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<http://review.cloudera.org/r/876/#comment4783>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<http://review.cloudera.org/r/876/#comment4784>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<http://review.cloudera.org/r/876/#comment4785>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<http://review.cloudera.org/r/876/#comment4786>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<http://review.cloudera.org/r/876/#comment4787>
Whitespace stuff and no comment for this parameter
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<http://review.cloudera.org/r/876/#comment4788>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<http://review.cloudera.org/r/876/#comment4789>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<http://review.cloudera.org/r/876/#comment4790>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<http://review.cloudera.org/r/876/#comment4791>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<http://review.cloudera.org/r/876/#comment4792>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
<http://review.cloudera.org/r/876/#comment4793>
src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java
<http://review.cloudera.org/r/876/#comment4794>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java
<http://review.cloudera.org/r/876/#comment4795>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java
<http://review.cloudera.org/r/876/#comment4796>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java
<http://review.cloudera.org/r/876/#comment4797>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java
<http://review.cloudera.org/r/876/#comment4798>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java
<http://review.cloudera.org/r/876/#comment4799>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java
<http://review.cloudera.org/r/876/#comment4800>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java
<http://review.cloudera.org/r/876/#comment4801>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java
<http://review.cloudera.org/r/876/#comment4802>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java
<http://review.cloudera.org/r/876/#comment4803>
Whitespace stuff
src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java
<http://review.cloudera.org/r/876/#comment4805>
Unnecessary, comments are automatically inherited
src/main/resources/hbase-default.xml
<http://review.cloudera.org/r/876/#comment4806>
Whitespace stuff
src/main/resources/hbase-default.xml
<http://review.cloudera.org/r/876/#comment4807>
Whitespace stuff
src/main/resources/hbase-default.xml
<http://review.cloudera.org/r/876/#comment4808>
Whitespace stuff
src/main/resources/hbase-default.xml
<http://review.cloudera.org/r/876/#comment4810>
Whitespace stuff
src/main/resources/hbase-default.xml
<http://review.cloudera.org/r/876/#comment4811>
Whitespace stuff
- Lars
> Coprocessors: Colocate user code with regions
> ---------------------------------------------
>
> Key: HBASE-2001
> URL: https://issues.apache.org/jira/browse/HBASE-2001
> Project: HBase
> Issue Type: Sub-task
> Reporter: Andrew Purtell
> Assignee: Mingjie Lai
> Fix For: 0.90.0
>
> Attachments: asm-transformations.pdf,
> HBASE-2001-RegionObserver-2.patch, HBASE-2001-RegionObserver.patch,
> HBASE-2001.patch.gz, packge-info.html, packge-info.html
>
>
> Support user code that runs run next to each region in table. As regions
> split and move, coprocessor code should automatically move also.
> Use classloader which looks on HDFS.
> Associate a list of classes to load with each table. Put this in HRI so it
> inherits from table but can be changed on a per region basis (so then those
> region specific changes can inherited by daughters).
> Not completely arbitrary code, should require implementation of an interface
> with callbacks for:
> * Open
> * Close
> * Split
> * Compact
> * (Multi)get and scanner next()
> * (Multi)put
> * (Multi)delete
> Add method to HRegionInterface for invoking coprocessor methods and
> retrieving results.
> Add methods in o.a.h.h.regionserver or subpackage which implement convenience
> functions for coprocessor methods and consistent/controlled access to
> internals: store access, threading, persistent and ephemeral state, scratch
> storage, etc.
> GitHub: http://github.com/mlai/hbase/tree/0.90_coprocessor
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
