[
https://issues.apache.org/jira/browse/HBASE-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918255#action_12918255
]
Nicolas Spiegelberg commented on HBASE-3084:
--------------------------------------------
My Comments
1. FSUtils.recoverFileLease() - does the InterruptedException handler need to
set Thread.currentThread().interrupt()? What about users actually trying to
kill the master?
2. parseHLog() - the comment says that len==0 can still happen with append
support? At least for 0.20, that's only if the file wasn't closed. However, we
just did that immediately before in recoverFileLease. don't mind the code, but
comment should change or be clarified
3. writeEditsBatchToRegions() - same thing with InterruptedException. maybe
want to have something higher up the call stack notice isInterrupted() and
display a Log.info() message. At the very least, we definitely don't want to
delete the log directory in splitLog() if the user interrupts these threads and
skipErrors==true
4. archiveLogs() - by default, we are archiving successfully split logs ala
'processedLogs'? I'm not sure we want to do that by default. I think people are
mainly interested in problematic logs that couldn't survive the transition.
Having this as an optional toggle is okay, but a naive user wouldn't know he
has these trash items.
> Address review comments raised post commit of hbase-2437, "Refactor HLog
> splitLog"
> ----------------------------------------------------------------------------------
>
> Key: HBASE-3084
> URL: https://issues.apache.org/jira/browse/HBASE-3084
> Project: HBase
> Issue Type: Bug
> Reporter: stack
>
> Nicolas reviewed hbase-2437 after it had been committed and raised some
> issues that need addressing:
> See
> https://issues.apache.org/jira/browse/HBASE-2437?focusedCommentId=12881937&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12881937
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
