[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922483#action_12922483 ]
Lars Francke commented on HBASE-1744: ------------------------------------- Oh great thanks Bryan (and Stack) for the review! * The typedef to Binary is just carried over from the old API, I thought it would be good to not confuse to much by suddenly changing that as well but you're probably right so I guess I'll change that as well. * I didn't even know about the Constants.java thing, thanks. I'll just introduce new namespaces. Is that a problem only with Java or the other languages as well? I'll have those changes in the next patch. > Thrift server to match the new java api. > ---------------------------------------- > > Key: HBASE-1744 > URL: https://issues.apache.org/jira/browse/HBASE-1744 > Project: HBase > Issue Type: Improvement > Components: thrift > Reporter: Tim Sell > Assignee: Lars Francke > Priority: Critical > Fix For: 0.92.0 > > Attachments: HBASE-1744.preview.1.patch, thriftexperiment.patch > > > This mutateRows, etc.. is a little confusing compared to the new cleaner java > client. > Thinking of ways to make a thrift client that is just as elegant. something > like: > void put(1:Bytes table, 2:TPut put) throws (1:IOError io) > with: > struct TColumn { > 1:Bytes family, > 2:Bytes qualifier, > 3:i64 timestamp > } > struct TPut { > 1:Bytes row, > 2:map<TColumn, Bytes> values > } > This creates more verbose rpc than if the columns in TPut were just > map<Bytes, map<Bytes, Bytes>>, but that is harder to fit timestamps into and > still be intuitive from say python. > Presumably the goal of a thrift gateway is to be easy first. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.