[ 
https://issues.apache.org/jira/browse/HBASE-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924140#action_12924140
 ] 

HBase Review Board commented on HBASE-3012:
-------------------------------------------

Message from: st...@duboce.net

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1077/#review1633
-----------------------------------------------------------


Looks great J-D but no +1 until you've added a unit test that proves your parse 
stuff in ZKUtil does the right thing when single ensemble member, many ensemble 
members, empty port spec., etc. (No need to post the patch with unit test -- 
just commit)


/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java
<http://review.cloudera.org/r/1077/#comment5492>

    Minor spacing issue here?
    


- stack





> TOF doesn't take zk client port for remote clusters
> ---------------------------------------------------
>
>                 Key: HBASE-3012
>                 URL: https://issues.apache.org/jira/browse/HBASE-3012
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>            Priority: Minor
>             Fix For: 0.90.0
>
>
> Currently we are only able to specify the ZK ensemble and root znode for the 
> remote cluster in TOF, we should also be able to give the client port (like 
> in replication). This will require a change in CopyTable's command line 
> arguments too.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to