[
https://issues.apache.org/jira/browse/HBASE-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930285#action_12930285
]
HBase Review Board commented on HBASE-3112:
-------------------------------------------
Message from: st...@duboce.net
bq. On 2010-11-09 11:05:46, Jean-Daniel Cryans wrote:
bq. > trunk/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java, line
444
bq. > <http://review.cloudera.org/r/1187/diff/5/?file=17034#file17034line444>
bq. >
bq. > I gave you my comments in person. Short version, I think that those
methods' method shouldn't change and that we should have methods clearly marked
as "async", and then do a job of educating people towards using them.
bq.
bq. Jean-Daniel Cryans wrote:
bq. I meant method's behavior
Yeah, I agree with you after chatting. Will fix (And you spotted prob. w/ way
async was running anyways).
bq. On 2010-11-09 11:05:46, Jean-Daniel Cryans wrote:
bq. >
trunk/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java,
line 135
bq. > <http://review.cloudera.org/r/1187/diff/5/?file=17043#file17043line135>
bq. >
bq. > Looks an awful lot like BulkDisabler
I disagree. The overrides each differ substantially (They look similar if you
don't look close -- smile).
- stack
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1187/#review1866
-----------------------------------------------------------
> Enable and disable of table needs a bit of loving in new master
> ---------------------------------------------------------------
>
> Key: HBASE-3112
> URL: https://issues.apache.org/jira/browse/HBASE-3112
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Priority: Critical
> Fix For: 0.90.0
>
> Attachments: 3112-v2.txt, 3112-v3.txt, 3112.txt
>
>
> The tools are in place to do a more reliable enable/disable of tables. Some
> work has been done to hack in a basic enable/disable but its not enough --
> see the test avro/thrift tests where a disable/enable/disable switchback can
> confuse the table state (and has been disabled until this issue addressed).
> This issue is about finishing off enable/disable in the new master. I think
> we need to add to the table znode an enabling/disabling state rather than
> have them binary with a watcher that will stop an enable (or disable)
> starting until the previous completes (Currently we atomically switch the
> state though the region close/open lags -- some work in enable/disable
> handlers helps in that they won't complete till all regions have
> transitioned.. but its not enough).
> Need to add tests too.
> Marking issue critical bug because loads of the questions we get on lists are
> about enable/disable probs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
