[
https://issues.apache.org/jira/browse/HBASE-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12973460#action_12973460
]
HBase Review Board commented on HBASE-3256:
-------------------------------------------
Message from: "Jonathan Gray" <jg...@apache.org>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1321/#review2126
-----------------------------------------------------------
Ship it!
great work! just a few small comments but otherwise +1
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
<http://review.cloudera.org/r/1321/#comment6607>
does DEFAULT really mean REGION/REGIONSERVER? or is it both?
not a big deal if it's just variable names but since it's a config param,
we should nail it now before it gets out in a release.
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
<http://review.cloudera.org/r/1321/#comment6608>
this code might have been in other earlier patches but could there be false
positives with this? it'd be silly to load FancyCoprocessor and then
MyFancyCoprocessor but i guess this is to cover the package? maybe parse out
the class name?
src/main/java/org/apache/hadoop/hbase/master/HMaster.java
<http://review.cloudera.org/r/1321/#comment6616>
doesn't preBalance() return a void? it's preBalanceSwitch that returns
boolean
src/main/java/org/apache/hadoop/hbase/master/HMaster.java
<http://review.cloudera.org/r/1321/#comment6617>
and here we should get the boolean return value (and base class should
return the input value)
src/main/java/org/apache/hadoop/hbase/master/HMaster.java
<http://review.cloudera.org/r/1321/#comment6618>
would we ever want to override default assign behavior? it's feasible...
might want to be future proof w/ the api?
src/main/java/org/apache/hadoop/hbase/master/HMaster.java
<http://review.cloudera.org/r/1321/#comment6619>
same here
- Jonathan
> Coprocessors: Coprocessor host and observer for HMaster
> -------------------------------------------------------
>
> Key: HBASE-3256
> URL: https://issues.apache.org/jira/browse/HBASE-3256
> Project: HBase
> Issue Type: Sub-task
> Reporter: Andrew Purtell
> Assignee: Gary Helmling
> Fix For: 0.92.0
>
> Attachments: HBASE-3256_initial.patch
>
>
> Implement a coprocessor host for HMaster. Hook observers into administrative
> operations performed on tables: create, alter, assignment, load balance, and
> allow observers to modify base master behavior. Support automatic loading of
> coprocessor implementation.
> Consider refactoring the master coprocessor host and regionserver coprocessor
> host into a common base class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
