[
https://issues.apache.org/jira/browse/HBASE-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018016#comment-13018016
]
jirapos...@reviews.apache.org commented on HBASE-3750:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/573/#review412
-----------------------------------------------------------
/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
<https://reviews.apache.org/r/573/#comment796>
I think the issue is more that this is now being called in putTable() which
doesn't declare itself to throw any exceptions.
The solution seems pretty simple. Make putTable() and
releaseHTableInterface() throw IOException and throw it directly instead of
wrapping in RuntimeException.
- Gary
On 2011-04-09 19:48:31, Ted Yu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/573/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-04-09 19:48:31)
bq.
bq.
bq. Review request for hbase and Lars George.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Currently HTablePool.putTable() doesn't call table.flushCommits()
bq. If AutoFlush is disabled for table instance, we should call
table.flushCommits().
bq.
bq. When HTable instance is discarded in putTable(), we should call
tableFactory.releaseHTableInterface().
bq.
bq.
bq. This addresses bug HBASE-3750.
bq. https://issues.apache.org/jira/browse/HBASE-3750
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/main/java/org/apache/hadoop/hbase/client/HTablePool.java 1090500
bq.
bq. Diff: https://reviews.apache.org/r/573/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. TestHTablePool passes.
bq.
bq.
bq. Thanks,
bq.
bq. Ted
bq.
bq.
> HTablePool.putTable() should call table.flushCommits()
> ------------------------------------------------------
>
> Key: HBASE-3750
> URL: https://issues.apache.org/jira/browse/HBASE-3750
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.1
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3750.txt
>
>
> Currently HTablePool.putTable() doesn't call table.flushCommits()
> This may turn out to be surprise for users
> When HTable instance is discarded in putTable(), we should call
> tableFactory.releaseHTableInterface().
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
