[ 
https://issues.apache.org/jira/browse/HBASE-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018729#comment-13018729
 ] 

stack commented on HBASE-3609:
------------------------------

Looking at patch, I see removal of testRandomizer.  Would be nice if a new test 
of new functionality took its place.

I like how you use regionid figuring region age.  Would suggest you add a 
little documentation that you depend on regionid being a timestamp (would also 
clarify what you are up to here).

Do you have to do this:

{code}+      boolean emptyRegionServerPresent) {code}

So this algorithm balances exclusively by age?   No randomness?

Would be nice if you described the algo in a comment included in the patch.

How we know this algo better than what we have?

Patch looks good otherwise Ted.

> Improve the selection of regions to balance; part 2
> ---------------------------------------------------
>
>                 Key: HBASE-3609
>                 URL: https://issues.apache.org/jira/browse/HBASE-3609
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: stack
>            Assignee: Ted Yu
>         Attachments: 3609-alternate.txt, 3609-empty-RS.txt, 
> hbase-3609-by-region-age.txt, hbase-3609.txt
>
>
> See 'HBASE-3586  Improve the selection of regions to balance' for discussion 
> of algorithms that improve on current random assignment.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to