[ https://issues.apache.org/jira/browse/HBASE-8662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703124#comment-13703124 ]
Matteo Bertozzi commented on HBASE-8662: ---------------------------------------- overall the patch looks good to me. last "fix" in 7.1.patch doesn't work with the 2.0 profile {code} [ERROR] hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java: [2087,31] non-static method refresh(org.apache.hadoop.conf.Configuration,org.apache.hadoop.security.authorize.PolicyProvider) cannot be referenced from a static context {code} also there're a couple of long lines {code} $ cat trunk-8662_v7.1.patch | grep "^+" | grep -v "^@@" | grep -v "^+++" | grep -v "import" | awk '{print length, $0}' | sort -nr| head 129 + new java.lang.String[] { "CallId", "TraceInfo", "MethodName", "RequestParam", "CellBlockMeta", "EffectiveUser", }, 109 + public static final String REST_AUTHENTICATION_PRINCIPAL = "hbase.rest.authentication.kerberos.principal"; 104 + new Call(AUTHROIZATION_FAILED_CALLID, this.service, null, null, null, this, null, 0, null, null); 103 + new Call(id, this.service, null, null, null, this, responder, totalRequestSize, null, null); 103 + new Call(id, this.service, null, null, null, this, responder, totalRequestSize, null, null); {code} > [rest] support impersonation > ---------------------------- > > Key: HBASE-8662 > URL: https://issues.apache.org/jira/browse/HBASE-8662 > Project: HBase > Issue Type: Sub-task > Components: REST, security > Reporter: Jimmy Xiang > Assignee: Jimmy Xiang > Fix For: 0.98.0 > > Attachments: method_doas.patch, secure_rest.patch, trunk-8662.patch, > trunk-8662_v2.patch, trunk-8662_v3.patch, trunk-8662_v4.patch, > trunk-8662_v5.patch, trunk-8662_v6.patch, trunk-8662_v7.1.patch, > trunk-8662_v7.patch > > > Currently, our client API uses a fixed user: the current user. It should > accept a user passed in, if authenticated. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira