[ https://issues.apache.org/jira/browse/HBASE-3777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026041#comment-13026041 ]
jirapos...@reviews.apache.org commented on HBASE-3777: ------------------------------------------------------ bq. On 2011-04-27 23:03:49, Ted Yu wrote: bq. > src/main/java/org/apache/hadoop/hbase/client/HTable.java, line 261 bq. > <https://reviews.apache.org/r/643/diff/3/?file=16912#file16912line261> bq. > bq. > We should place deleteConnection() call in finally block because isTableEnabled() may throw IOException: bq. > bq. > public boolean isTableEnabled(byte[] tableName) throws IOException; bq. > bq. > Looks like we should use Connectable that Karthick proposed. Yes, the delete now happens inside of a finally block in the current version, which was just rebased with the trunk, and is currently undergoing testing. - Karthick ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/643/#review591 ----------------------------------------------------------- On 2011-04-27 18:33:01, Karthick Sankarachary wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/643/ bq. ----------------------------------------------------------- bq. bq. (Updated 2011-04-27 18:33:01) bq. bq. bq. Review request for hbase and Ted Yu. bq. bq. bq. Summary bq. ------- bq. bq. Judging from the javadoc in HConnectionManager, sharing connections across multiple clients going to the same cluster is supposedly a good thing. However, the fact that there is a one-to-one mapping between a configuration and connection instance, kind of works against that goal. Specifically, when you create HTable instances using a given Configuration instance and a copy thereof, we end up with two distinct HConnection instances under the covers. Is this really expected behavior, especially given that the configuration instance gets cloned a lot? bq. bq. Here, I'd like to play devil's advocate and propose that we "deep-compare" HBaseConfiguration instances, so that multiple HBaseConfiguration instances that have the same properties map to the same HConnection instance. In case one is "concerned that a single HConnection is insufficient for sharing amongst clients", to quote the javadoc, then one should be able to mark a given HBaseConfiguration instance as being "uniquely identifiable". bq. bq. bq. This addresses bug HBASE-3777. bq. https://issues.apache.org/jira/browse/HBASE-3777 bq. bq. bq. Diffs bq. ----- bq. bq. src/main/java/org/apache/hadoop/hbase/HConstants.java 5701639 bq. src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java be31179 bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java afb666a bq. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java c348f7a bq. src/main/java/org/apache/hadoop/hbase/client/HTable.java edacf56 bq. src/main/java/org/apache/hadoop/hbase/client/HTablePool.java 88827a8 bq. src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 9e3f4d1 bq. src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationAdmin.java d76e333 bq. src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java ed88bfa bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java 79a48ba bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java d0a1e11 bq. src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java 78c3b42 bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 5da5e34 bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java b624d28 bq. src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 7f5b377 bq. src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java dc471c4 bq. src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java e25184e bq. src/test/java/org/apache/hadoop/hbase/catalog/TestMetaReaderEditor.java 60320a3 bq. src/test/java/org/apache/hadoop/hbase/client/TestHCM.java b01a2d2 bq. src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduce.java 624f4a8 bq. src/test/java/org/apache/hadoop/hbase/util/TestMergeTable.java 8992dbb bq. bq. Diff: https://reviews.apache.org/r/643/diff bq. bq. bq. Testing bq. ------- bq. bq. mvn test bq. bq. bq. Thanks, bq. bq. Karthick bq. bq. > Redefine Identity Of HBase Configuration > ---------------------------------------- > > Key: HBASE-3777 > URL: https://issues.apache.org/jira/browse/HBASE-3777 > Project: HBase > Issue Type: Improvement > Components: client, ipc > Affects Versions: 0.90.2 > Reporter: Karthick Sankarachary > Assignee: Karthick Sankarachary > Priority: Minor > Fix For: 0.92.0 > > Attachments: 3777-TOF.patch, HBASE-3777-V2.patch, > HBASE-3777-V3.patch, HBASE-3777-V4.patch, HBASE-3777-V6.patch, > HBASE-3777.patch > > > Judging from the javadoc in {{HConnectionManager}}, sharing connections > across multiple clients going to the same cluster is supposedly a good thing. > However, the fact that there is a one-to-one mapping between a configuration > and connection instance, kind of works against that goal. Specifically, when > you create {{HTable}} instances using a given {{Configuration}} instance and > a copy thereof, we end up with two distinct {{HConnection}} instances under > the covers. Is this really expected behavior, especially given that the > configuration instance gets cloned a lot? > Here, I'd like to play devil's advocate and propose that we "deep-compare" > {{HBaseConfiguration}} instances, so that multiple {{HBaseConfiguration}} > instances that have the same properties map to the same {{HConnection}} > instance. In case one is "concerned that a single {{HConnection}} is > insufficient for sharing amongst clients", to quote the javadoc, then one > should be able to mark a given {{HBaseConfiguration}} instance as being > "uniquely identifiable". > Note that "sharing connections makes clean up of {{HConnection}} instances a > little awkward", unless of course, you apply the change described in > HBASE-3766. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira