[ https://issues.apache.org/jira/browse/HBASE-8873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13708036#comment-13708036 ]
Liang Xie commented on HBASE-8873: ---------------------------------- the compaction trigger condition will be inaccurate sometimes. e.g. set minFilesToCompact=3, it probably trigger a minor compaction while storefiles.size() - filesCompacting.size() = 2. or storefiles.size() - filesCompacting.size() = 4, but didn't trigger a normal minor compaction request. > minor concurrent issue about filesCompacting > -------------------------------------------- > > Key: HBASE-8873 > URL: https://issues.apache.org/jira/browse/HBASE-8873 > Project: HBase > Issue Type: Bug > Affects Versions: 0.95.1, 0.94.9 > Reporter: Liang Xie > Assignee: Liang Xie > Attachments: HBase-8873-0.94.txt > > > i am reading compaction code, seems there's a minor thread-safe issue on > filesCompacting in both 0.94 and trunk, we guard it with synchronized/lock, > except needsCompaction() function. and the fix should sth like this: > synchronized (filesCompacting) { > ... > } -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira