[
https://issues.apache.org/jira/browse/HBASE-3777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027914#comment-13027914
]
jirapos...@reviews.apache.org commented on HBASE-3777:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/643/#review632
-----------------------------------------------------------
Ship it!
I think a patch for 0.90 should be produced separately.
We have informed hbase users of this change. They would expect to benefit from
it in 0.90
- Ted
On 2011-05-02 21:34:35, Karthick Sankarachary wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/643/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-05-02 21:34:35)
bq.
bq.
bq. Review request for hbase and Ted Yu.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Judging from the javadoc in HConnectionManager, sharing connections across
multiple clients going to the same cluster is supposedly a good thing. However,
the fact that there is a one-to-one mapping between a configuration and
connection instance, kind of works against that goal. Specifically, when you
create HTable instances using a given Configuration instance and a copy
thereof, we end up with two distinct HConnection instances under the covers. Is
this really expected behavior, especially given that the configuration instance
gets cloned a lot?
bq.
bq. Here, I'd like to play devil's advocate and propose that we "deep-compare"
HBaseConfiguration instances, so that multiple HBaseConfiguration instances
that have the same properties map to the same HConnection instance. In case one
is "concerned that a single HConnection is insufficient for sharing amongst
clients", to quote the javadoc, then one should be able to mark a given
HBaseConfiguration instance as being "uniquely identifiable".
bq.
bq.
bq. This addresses bug HBASE-3777.
bq. https://issues.apache.org/jira/browse/HBASE-3777
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/HConstants.java 0911375
bq. src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java
feed777
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java fa7448b
bq. src/main/java/org/apache/hadoop/hbase/client/HConnection.java 1beedaf
bq. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
ded51c8
bq. src/main/java/org/apache/hadoop/hbase/client/HTable.java 46bac9f
bq. src/main/java/org/apache/hadoop/hbase/client/HTablePool.java 88827a8
bq. src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 26d0b31
bq.
src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationAdmin.java
d76e333
bq. src/main/java/org/apache/hadoop/hbase/mapred/TableOutputFormat.java
80284bb
bq. src/main/java/org/apache/hadoop/hbase/mapreduce/TableOutputFormat.java
05d9395
bq.
src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java
ed88bfa
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java f526411
bq. src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 834c456
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
421f275
bq.
src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationLogCleaner.java
133da33
bq.
src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
fc71f03
bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 1c1d94b
bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java 39f3af2
bq. src/main/java/org/apache/hadoop/hbase/util/HMerge.java c447287
bq. src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java a4def94
bq. src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
dc471c4
bq. src/test/java/org/apache/hadoop/hbase/TestRegionRebalancing.java 75613b8
bq. src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java
ae333bb
bq. src/test/java/org/apache/hadoop/hbase/catalog/TestMetaReaderEditor.java
18e647e
bq. src/test/java/org/apache/hadoop/hbase/client/TestHCM.java 5d71d75
bq. src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduce.java
624f4a8
bq. src/test/java/org/apache/hadoop/hbase/master/TestClockSkewDetection.java
752e12b
bq. src/test/java/org/apache/hadoop/hbase/util/TestMergeTable.java 8992dbb
bq.
bq. Diff: https://reviews.apache.org/r/643/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. mvn test
bq.
bq.
bq. Thanks,
bq.
bq. Karthick
bq.
bq.
> Redefine Identity Of HBase Configuration
> ----------------------------------------
>
> Key: HBASE-3777
> URL: https://issues.apache.org/jira/browse/HBASE-3777
> Project: HBase
> Issue Type: Improvement
> Components: client, ipc
> Affects Versions: 0.90.2
> Reporter: Karthick Sankarachary
> Assignee: Karthick Sankarachary
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: 3777-TOF.patch, HBASE-3777-V2.patch,
> HBASE-3777-V3.patch, HBASE-3777-V4.patch, HBASE-3777-V6.patch,
> HBASE-3777.patch
>
>
> Judging from the javadoc in {{HConnectionManager}}, sharing connections
> across multiple clients going to the same cluster is supposedly a good thing.
> However, the fact that there is a one-to-one mapping between a configuration
> and connection instance, kind of works against that goal. Specifically, when
> you create {{HTable}} instances using a given {{Configuration}} instance and
> a copy thereof, we end up with two distinct {{HConnection}} instances under
> the covers. Is this really expected behavior, especially given that the
> configuration instance gets cloned a lot?
> Here, I'd like to play devil's advocate and propose that we "deep-compare"
> {{HBaseConfiguration}} instances, so that multiple {{HBaseConfiguration}}
> instances that have the same properties map to the same {{HConnection}}
> instance. In case one is "concerned that a single {{HConnection}} is
> insufficient for sharing amongst clients", to quote the javadoc, then one
> should be able to mark a given {{HBaseConfiguration}} instance as being
> "uniquely identifiable".
> Note that "sharing connections makes clean up of {{HConnection}} instances a
> little awkward", unless of course, you apply the change described in
> HBASE-3766.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
