[ https://issues.apache.org/jira/browse/HBASE-7826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13717471#comment-13717471 ]
Hadoop QA commented on HBASE-7826: ---------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12593740/hbase_7826_sortcolumnFlag.4.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop 1.0 profile. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6439//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6439//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6439//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6439//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6439//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6439//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6439//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6439//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6439//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6439//console This message is automatically generated. > Improve Hbase Thrift v1 to return results in sorted order > --------------------------------------------------------- > > Key: HBASE-7826 > URL: https://issues.apache.org/jira/browse/HBASE-7826 > Project: HBase > Issue Type: New Feature > Components: Thrift > Affects Versions: 0.94.0 > Reporter: Shivendra Pratap Singh > Assignee: Shivendra Pratap Singh > Priority: Minor > Labels: Hbase, Thrift > Attachments: hbase_7826.patch, hbase_7826.patch, > hbase_7826_sortcolumnFlag.1.patch, hbase_7826_sortcolumnFlag.2.patch, > hbase_7826_sortcolumnFlag.3.patch, hbase_7826_sortcolumnFlag.4.patch, > hbase_7826_sortcolumnFlag.patch, hbase_7826_trunk.patch > > > Hbase natively stores columns sorted based on the column qualifier. A scan is > guaranteed to return sorted columns. The Java API works fine but the Thrift > API is broken. Hbase uses TreeMap that ensures that sort order is maintained. > However Hbase thrift specification uses a simple Map to store the data. A > map, since it is unordered doesn't result in columns being returned in a sort > order that is consistent with their storage in Hbase. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira