[ 
https://issues.apache.org/jira/browse/HBASE-3833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028900#comment-13028900
 ] 

Vishal Kathuria commented on HBASE-3833:
----------------------------------------

Thank you for the comments folks. I wasn't aware of HDFS-1547 - I just looked 
through it.

Here are my thoughts
1. Agree with doing a graceful shutdown of the region server that is being 
excluded.
2. I would like to hear from folks regarding what they think of storing these 
files in zk. Heck, why shouldn't we store the entire config in zk and the only 
config you need is the address of the zk cluster?
3. Regarding the name, I will change the file to decom instead of exclude for 
consistency with HDFS. One difference with 1547 is that 1547 leaves those nodes 
up and I am shutting them down. I don't see the value of keeping those nodes up 
so I will stay with that unless you folks think otherwise.
4. Re Todd's suggestion on the truth table, is it okay if I publish the boolean 
expression in the documentation. I have an easier time inferring the intuition 
from a boolean expression than a truth table.
5. stack: I will update the licenses to 2011 and look at the spaces again. My 
intent was to use 2 but I may have missed some places.
6. The change in .sh file is intentional, otherwise the script for starting the 
local region server was not working. I need to make sure the change doesn't 
break any of the other scripts. I will verify that.

Thanks again folks.
Vishal 

> ability to support includes/excludes list in Hbase
> --------------------------------------------------
>
>                 Key: HBASE-3833
>                 URL: https://issues.apache.org/jira/browse/HBASE-3833
>             Project: HBase
>          Issue Type: Improvement
>          Components: client, regionserver
>    Affects Versions: 0.90.2
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>         Attachments: excl-patch.txt
>
>
> An HBase cluster currently does not have the ability to specify that the 
> master should accept regionservers only from a specified list. This helps 
> preventing administrative errors where the same machine could be included in 
> two clusters. It also allows the administrator to easily remove un-ssh-able 
> machines from the cluster.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to